New Rule: require global regular expression to be used with `replaceAll`

Rule details

When replaceAll is given a regular expression as its first argument, that regular expression must be global. If it’s not global, a runtime error is thrown. This rule should require that regular expressions passed as the first argument to replaceAll are global.

Related ECMAScript feature

String.prototype.replaceAll: https://github.com/tc39/proposal-string-replaceall

What type of rule is this?

Warns about a potential problem

Example code

`abc`.replaceAll(/a/, ``) // throws Uncaught TypeError: String.prototype.replaceAll called with a non-global RegExp argument

// Should be an error, and could also have an auto-fix to change the code to `abc`.replaceAll(/a/g, ``)

Why should this rule be in the core instead of a plugin?

It prevents a runtime error that’s not otherwise apparent.

Participation

• I am willing to submit a pull request to implement this rule.

Additional comments

It’d be nice to reopen https://github.com/eslint/eslint/issues/12557, too.

[Tyler-Murphy]

@bmish, I think that’s different. Maybe for https://github.com/eslint/eslint/issues/12557?

[mdjermanovic]

It sounds like no-restricted-syntax might be able to cover the case I’m thinking of. Do you think it could?

This selector would cover regex literals:

CallExpression[callee.property.name='replaceAll'] > Literal[regex.flags=/^[^g]*$/].arguments:first-child

Online Demo