no-constant-condition should allow for while(true) idiom

What version of ESLint are you using?

2.3.0

What configuration and parser (Espree, Babel-ESLint, etc.) are you using?

env: es6 + node parser: Espree config: “no-constant-condition”: “error”

What did you do? Please include the actual source code causing the issue.

while (true)
{
    if (doSomething())
        break;
}

What did you expect to happen?

I expected no error at the while, because its dependent statement has a break, and in this case it’s equivalent to for(;;). Maybe I’m the only one who uses this idiom.

What actually happened? Please include the actual, raw output from ESLint.

line 15, col 1, Error - Unexpected constant condition. (no-constant-condition)

line 15, col 1 is the “w” in while.

What do you suggest?

There are three approaches to fixing this:

1. Ignore it and hope I go away. 😉
2. Always allow while (true) the way for (;;) is allowed.
3. Add an “allow-while-true” option.

I’ll be happy to implement it, but let me know which approach you want to take.

[dead-claudia]

I feel an extra option for no-constant-condition to allow explicit boolean literals would be nice. I personally find while (true) more readable and the intent more explicit than for (;;). Also, there’s the do { ... } while (false) idiom, for which there is no substitute other than labelled blocks, which IMHO are ugly.

for (;;) {
  doSomething()
  if (condition()) return null
}

while (true) {
  doSomething()
  if (condition()) return null
}

As for boolean literal conditions in if (true), etc., that can still be caught by no-unreachable-code.

So 👍 from me.

[aparajita]

@kaicataldo Go for it.