no-dupe-keys - warn about non-static key names with similar AST

What rule do you want to change? no-dupe-keys

Does this change cause the rule to produce more or fewer warnings? More

How will the change be implemented? (New option, new default behavior, etc.)? Right now rule works only with static property names https://github.com/eslint/eslint/blob/master/lib/rules/no-dupe-keys.js#L122

Rule could also check for calculated property names with similar AST

Please provide some example code that this change will affect:

/* eslint-disable no-console */
const obj1 = {
    ['aaa']: 1,
    ['aaa']: 1 // here duplicate keys are detected
};

const name = 'aaa';

const obj2 = {
    [name]: 1,
    [name]: 1 // here duplicate keys are not detected
};

console.log(obj1, obj2);

What does the rule currently do for this code? Rule detects duplicate keys only in obj1

  4:6  error  Duplicate key 'aaa'  no-dupe-keys

✖ 1 problem (1 error, 0 warnings)

What will the rule do after it’s changed? The rule will detect also duplicate keys in obj2

  4:6  error  Duplicate key 'aaa'  no-dupe-keys
 11:6  error  Duplicate key [name]  no-dupe-keys

✖ 2 problems (2 errors, 0 warnings)

[victor-homyakov]

@platinumazure I changed the initial post according to the rule enhancement proposal template

[ljharb]

Is there a reason this wasn’t accepted? Can it be revisited?