no-empty-function false positive

Tell us about your environment

• ESLint Version: 6.8.0
• Node Version: 12.14.1
• npm Version: 6.13.4

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration

{
  "no-empty-function": ["error", { "allow": ["methods"] }]
}

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

const object = {
  async method() {}
};

eslint .

What did you expect to happen?

No no-empty-function warnings.

What actually happened? Please include the actual, raw output from ESLint.

Unexpected empty async method ‘method’. (no-empty-function)

Are you willing to submit a pull request to fix this bug?

Yes

[kaicataldo]

On thinking about this more, this seems like a clear case of an unintentionally missing feature (it was probably implemented before async functions were added to the language). The rule definitely doesn’t feel complete without it, so I’m marking as accepted. If anyone from the team disagrees, please let me know!

[mdjermanovic]

I also think this should be fixed in some way. There are also async arrow functions.

By the current implementation, it seems that async generator functions and async generator methods would be treated as just generator functions/generator methods? Looks like there could be an exponential growth of options if something new appears.