no-fallthrough does not allow comments between empty cases

Multiple cases with a single body are always allowed but placing comments between the cases is not allowed.

switch(foo) {
case 1:
case 2:
doSomething();
}

switch(foo) {
// We need to handle 1.
case 1:
// We also need to handle 2.
case 2:
doSomething();
}

The latter is not valid as the comment between case 1 and case 2 is not allowed. Would be great if it was possible to comment on individual cases without having to add the “fallthrough” comment after that.

[kaicataldo]

There’s also the commentPattern: option: http://eslint.org/docs/rules/no-fallthrough#commentpattern

If you don’t want this behavior, wouldn’t it best to just turn the rule off? It sounds like what you’re trying to enforce is having ANY comment between cases make the rule consider the fall through case as valid, which is error prone and seems to me to defeat the purpose of enabling the rule.

Apologies if I’m misunderstanding something here and, if that’s the case, can you fill out the rule enhancement template as was requested when you first made the issue?

[not-an-aardvark]

It looks like there hasn’t been any activity on this issue for awhile, and there are two 👎s from team members, so I’m going to go ahead and close it. Of course, you can always implement this behavior yourself as part of a custom rule.