`no-regex-spaces`: Add RegExp object form

The docs for this rule specifically call out that the following will not be considered a warning:

/*eslint no-regex-spaces: 2*/

var re = new RegExp("foo   bar");

This seems to be a limitation, as it is not asserted in the tests, and intuitively it seems that the RegExp object format should be treated the same way as a literal, multiple spaces are equally hard to read in both.

<bountysource-plugin>

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource. </bountysource-plugin>

[IanVS]

From the rule docs:

The following patterns are considered warnings:

var re = /foo   bar/;

The following patterns are not warnings:

var re = new RegExp("foo   bar");

In most of the docs, the “not warnings” section is used to show how to “fix” the code so that the rule will no longer flag. So, what I’m proposing is:

The following patterns are considered warnings:

var re = /foo   bar/;

The following patterns are not warnings:

var re = /foo {3}bar/;

Known Limitations

This rule does not apply to the constructor form of RegExp, and therefore the following will not warn:

var re = new RegExp("foo   bar");

[IanVS]

Cool, I’d be all for that, and @nzakas has said

I’m not against adding it

So I’d say go for it. 😃