no-unreachable: break after continue in switch statement incorrectly flagged

/* eslint no-unreachable: 2 */
var node = document.body.childNodes[0], visibleNodes = [], miscNodes = []
while (node = node.nextSibling) {
  switch (node.nodeType) {
    case Node.ELEMENT_NODE:
      nodes.push(node);
      break;
    case Node.TEXT_NODE:
      nodes.push(node);
      break;
    case Node.COMMENT_NODE:
      continue; // refers to the while() loop, will not terminate execution in this case
      break; // triggers no-unreachable
    default:
      miscNodes.push(node);
  }
}

Reported in 2.0.0-beta.3

Seems to be a regression from https://github.com/eslint/eslint/issues/1220 / https://github.com/eslint/eslint/pull/1221

[not-an-aardvark]

@gheljenor To avoid that issue, you should enable the no-fallthrough rule.

[gheljenor]

May i reopen this?

In this case break; is not really needed, but… Imagine such case of refactoring:

switch(a) {
	case 1:
		return "one";
	case 2: 
		return "two";
}

Then we decide, to decorate output and do something like this:

var result;
switch(a) {
	case 1:
		result = "one";
	case 2:
		result = "two";
}
return {value: result};

If there is no rule ‘no-fallthrough’ - we’ll break our code. It seems, better to keep break; statements in switch-case, even they are unreachable.