'no-unsafe-finally' rule gives errors on safe code

What version of ESLint are you using? eslint@e606523

What parser (default, Babel-ESLint, etc.) are you using? default

What did you do? Please include the actual source code causing the issue. Rule no-unsafe-finally gives an error on the following code:

try {} finally {
  while(true) {
    break;
  }
}

What did you expect to happen? No errors.

What actually happened? Please include the actual, raw output from ESLint. Unsafe usage of BreakStatement no-unsafe-finally

More generally, break and continue statements need to check that the statement being broken or continued is not interior to the finally block. This involves checking labels, if present.

ping @onurtemizkan, @platinumazure.

See #5808, #5932.

[bakkot]

@louy, that one’s handled correctly.

Easiest way to test it yourself is to clone master, npm install, then ./bin/eslint.js --no-eslintrc --rule 'no-unsafe-finally: 1' test.js.

[mysticatea]

Oh, good catch!