no-unused-vars highlights at wrong position

With no-unused-vars enabled eslint highlights the last use of the variable. If it is used left and right of an assignment it should mark the one on the left.

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

Instead of this:

let x = [];
x = x.concat(x);
             ^

What did you expect to happen? It should be this:

let x = [];
x = x.concat(x);
^

What actually happened? Please copy-paste the actual, raw output from ESLint.

Steps to reproduce this issue:

1. eslint demo

Are you willing to submit a pull request to fix this bug? No

[nzakas]

@aladdin-add we chose to highlight the last reference because that’s where the most likely error is. It’s easy to find the declaration but that last reference might not be obvious.

@snitin315 basically, you want the last write reference. You can tell by using ref.isWrite().

[aladdin-add]

@snitin315 please feel free to open a PR! 😄