question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`no-unused-vars` message does not end with a period

See original GitHub issue

What version of ESLint are you using?

2.10.2

What parser (default, Babel-ESLint, etc.) are you using?

Default

Please show your full configuration:

const options = {
  // TODO: Actually set the envs correctly
  envs: ['browser', 'mocha', 'node', 'es6'],
  useEslintrc: false,
  extends: 'eslint:recommended',
  ignorePattern: [
    'node_modules',
    'bower_components',
    'build',
    'tmp',
    'dist'
  ],
  // Eventually let's enable it to fix problems automatically! :D
  // fix: true,
  rules: {
    semi: WARN,
    strict: [WARN, 'safe'],
    'no-undef': ERROR,
    'wrap-iife': WARN,
    'no-trailing-spaces': WARN,
    'comma-style': [WARN, 'last'],
    'new-parens': WARN,
    'no-inline-comments': WARN,
    'no-sequences': ERROR,
    'no-alert': WARN,
    'no-caller': WARN,
    'no-lone-blocks': WARN,
    'object-curly-spacing': [WARN, 'never'],
    'space-infix-ops': WARN,
    'space-unary-ops': [WARN, {words: true, nonwords: false}],
    'spaced-comment': [WARN, 'always'],
    'no-unused-vars': [WARN, {argsIgnorePattern: '^_'}]
  }
};

What did you do? Please include the actual source code causing the issue.

I linted code and got back a message without a period.

const cli = new eslint.CLIEngine(eslintOptions);

function lint(req, res) {
  if ('paths' in req.body) {
    const report = cli.executeOnFiles(req.body.paths);
    if (eslintOptions.fix) {
      eslint.CLIEngine.outputFixes(report);
    }
    res.json(report);
  } else {
    res.status(S.BAD_REQUEST).json({
      error: 'Missing parameter "path"'
    });
  }
}

What did you expect to happen?

I expected the message from the no-unused-vars rule to include a period at the end, like the other messages from ESLint.

What actually happened? Please include the actual, raw output from ESLint.

https://gist.github.com/wavebeem/98136a4d2823a43716e76651571473a6

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
ilyavolodincommented, Jul 22, 2016
0reactions
wavebeemcommented, Jul 22, 2016

@nzakas I already have, but it needs some work still (https://github.com/eslint/eslint/pull/6739)

Read more comments on GitHub >

github_iconTop Results From Across the Web

Getting @typescript-eslint/no-unused-vars warning occurs ...
The error can be resolved by adding the 'include' property. include specifies an array of filenames or patterns to include in the program....
Read more >
vue/jsx-uses-vars
Since 0.17.0 the ESLint no-unused-vars rule does not detect variables used in JSX (see details). This rule will find variables used in JSX ......
Read more >
eslint-plugin-jsdoc - npm
The following will report the message @extends is to be used over @augments as it is more evocative of classes than @augments upon ......
Read more >
No More Periods in Texting. Period. - The New York Times
The consensus is that many texters, especially young people, see end-of-message periods as tonally significant because they are unnecessary. It ...
Read more >
demo-outil-edition - node_modules - eslint - CHANGELOG.md
... 4c87f42 Fix: incorrect error messages of no-unused-vars (fixes #9774) ... b3e4598 Fix: clarify AST and don't use node.start / node.end ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found