no-useless-return has a false negative with try/catch

Tell us about your environment

• ESLint Version: 3.9.0
• Node Version: 6.9.1
• npm Version: 3.10.8

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

rules:
  no-useless-return: error

What did you do? Please include the actual source code causing the issue.

function foo() {
  try {
    return;
  } catch (err) {
    foo();
  }
}

What did you expect to happen?

This should report an error, because the return statement can be safely removed.

What actually happened? Please include the actual, raw output from ESLint.

No error.

[mysticatea]

Thank you for this issue.

In fact, this is caused by the current code path analyzer. Since the analyzer cannot know the places which throw exceptions, it generates 2 code paths which go to the catch block from both the first statement and the last statement in the try block (edit: and from throw statements). But in this case, the return; statement throws no exception clearly. I will investigate to improve the code path.

[ljharb]

This has an open PR, #16693