Overrides not applied

Environment

• ESLint Version: 4.18.2 and 4.19.1
• Node Version: 6.11.3
• ~npm~ Yarn Version: 1.5.1

What parser (default, Babel-ESLint, etc.) are you using?

babel-eslint

Configuration

project/.eslintrc

{
  "env": {
    "es6": true
  },
  "extends": "airbnb", // includes func-names, no-unused-expressions, prefer-arrow-callback
  "parser": "babel-eslint",
  "parserOptions": {
    "ecmaVersion": 2018
  },
  "plugins": [
    "import"
  ],
  "root": true,
  "rules": {
    // …
  },
  "overrides": [
    {
      // for spec files
      "env": {
        "mocha": true,
      },
      "files": [
        "**/*.spec.js",
        "**/*.spec.jsx"
      ],
      "rules": {
        "func-names": "off",
        "no-unused-expressions": "off",
        "prefer-arrow-callback": [
          "error",
          "never"
        ]
      }
    }
  ],
  "settings": {
    "import/resolver": "webpack"
  }
}

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

project/src/…/index.spec.jsx

describe('SomeComponent', function () {
  // …
});

What did you expect to happen?

Overrides to be applied

What actually happened? Please include the actual, raw output from ESLint.

Errors for all 3 rules in the override block

22:1   error    'describe' is not defined        no-undef
22:32  error    Unexpected function expression   prefer-arrow-callback
22:32  warning  Unexpected unnamed function      func-names

[aladdin-add]

@zetaraku in your case, the env should be top-level.

{
  "files": [...],
  "env": {
   ...
  }
}

[donaldpipowitch]

For me it doesn’t seem to work when I write my config like this:

module.exports = {
  ...require('./some-shared-config'),
  overrides: [
    {
      files: [`*.js`],
      rules: {
        'no-console': 'off'
      }
    }
  ]
};

Adding overrides directly into './some-shared-config' works, but I’d expect it to behave in the same way 🤔

It looks like this doesn’t work either:

module.exports = {
  extends: './packages/ws/.eslintrc.js',
  overrides: [
    {
      files: [`*.js`],
      rules: {
        'no-console': 'off'
      }
    }
  ]
};

Update

It looks like I needed to rename my .eslintrc.js which I used as a base (e.g. .eslintrc.base.js).