question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Perfomance degradation in import plugin after eslint 6

See original GitHub issue

Tell us about your environment

  • ESLint Version: tested on latest versions of 5,6,7
  • Node Version: 12.18.3
  • npm Version: 6.14.6 What parser (default, @babel/eslint-parser, @typescript-eslint/parser, etc.) are you using? default

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

Updated eslint from version 5 to 6 and 7.

What did you expect to happen?

Expected no performance degradation, before update timing looked like this:

image

What actually happened? Please include the actual, raw output from ESLint. Actually after update to 6 or 7 version I got insane degradation in eslint import plugin. image Nothing else besides eslint version was changed. Also tried installing latest version of import plugin but go the same picture. Seems like there is some important change in Eslint 6.0. I looked through release notes but couldn’t find the problem yet.

Are you willing to submit a pull request to fix this bug? No, still not sure what in Elint caused this problem. Help wanted.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:5
  • Comments:15 (6 by maintainers)

github_iconTop GitHub Comments

6reactions
nzakascommented, Oct 1, 2020

There’s likely not an issue with the import plugin at all. Note that the rule order is different before and after upgrading. It’s not the rules or the plugin that is the problem, it’s all the bootstrapping ESLint is doing before even running the first rule.

Config is pretty complicated, which is why we are replacing it with a simpler system. Unfortunately, I don’t think we can boost the performance of configs right now without jeopardizing current work. I’m pushing forward on #13481 as fast as I can.

1reaction
nzakascommented, Oct 6, 2020

FYI there is an issue open for separation of bootstrap costs from rule performance: https://github.com/eslint/eslint/issues/13695

Read more comments on GitHub >

github_iconTop Results From Across the Web

Migrating to v6.0.0 - ESLint - Pluggable JavaScript Linter
As a rule of thumb: With ESLint v6, plugins should always be installed locally, even if ESLint was installed globally.
Read more >
12 essential ESLint rules for React - LogRocket Blog
Introduction. ESLint has a comprehensive set of rules for JavaScript code that cover stylistic choices and prevent common bugs.
Read more >
How to Bundle JavaScript With Rollup — Step-by-Step Tutorial
This week, we're going to build our first project using Rollup, which is a build tool for bundling JavaScript (and stylesheets, but we'll...
Read more >
ESLint - Nova Extensions - Panic Inc.
ESLint Extension for Nova. Provides integration with ESLint to lint your code. Features. Inline ESLint issue reporting; "Fix All Issues" command ...
Read more >
@flyacts/eslint-config - npm
or install following dependencies manually: npm install --save-dev --save-exact eslint@8.3.0 @typescript-eslint/eslint-plugin@5.5.0 ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found