prefer-rest-params: ignore uses of ...arguments

I would like to suggest a change to the prefer-rest-params rule.

My use case is thus:

// constructor of this subclass takes arguments a, b, c, d, e, f
constructor(a) {
  super(...arguments);
  doSomethingSpecialWith(a);
}

In cases where a function takes many arguments, and you only want to operate on a subset, prefer-rest-params forces patterns like these:

constructor(a, ...rest) {
  super(a, ...rest);
  doSomethingSpecialWith(a);
}

constructor(...args) {
  const [a] = args;
  super(...args);
  doSomethingSpecialWith(a);
}

The first pattern is not ideal because you have to change code in two places now if you change what variables you’re using. The second pattern is not ideal in my opinion because it’s added what seems to me to be mental overhead.

---

I would like to suggest that prefer-rest-params should not fire if the only use of arguments in a function is to spread it.

The following patterns would not be errors:

constructor(a) {
  super(...arguments);
  doSomethingSpecialWith(a);
}

The following patterns would still be errors:

constructor(a) {
  super(...arguments);
  doSomethingSpecialWith(arguments[0]);
}

[sethkinast]

The linked “Rule Change Proposal Template” at http://eslint.org/docs/developer-guide/contributing/rule-changes is 404

[vitorbal]

@mathieug please open a new issue or drop by our Gitter chat if you need any help. Thanks!