question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove non-recommended rules from recommended config

See original GitHub issue

The version of ESLint you are using.

5.6.0/master

The problem you want to solve.

The eslint:recommended config contains all ESLint rules. Non-recommended rules are explicitly set to “off”, while recommended rules are set to “error”.

This impacts users who might wish to extend eslint:recommended after having already extended a different configuration. The rules configured as “off” will override any rules configured as “warn” or “error” in the extended configuration.

In practice, this is pretty rare. However, it also seems that eslint:recommended should not explicitly turn off other rules.

Inspired by #10816.

Your take on the correct solution to problem.

Remove the “off” rules from eslint:recommended. This is technically a breaking change, so we should do this within a major release.

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:5
  • Comments:6 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
btmillscommented, Jan 31, 2019

This has been accepted for the next major release!

0reactions
platinumazurecommented, Feb 6, 2019

Working on this.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Rules - ESLint - Pluggable JavaScript Linter
The "extends": "eslint:recommended" property in a configuration file enables this ... These rules relate to possible logic errors in code: ... no-delete-var.
Read more >
eslint-plugin-eslint-plugin - npm
Enables the recommended configuration; Enables an optional/non-recommended rule. { "parserOptions": { "sourceType": " ...
Read more >
eslint-plugin-eslint-plugin | Yarn - Package Manager
Sets sourceType to script for CJS plugins (most users) (use module for ESM/TypeScript); Enables the recommended configuration; Enables an optional/non- ...
Read more >
Validation Rule Suggestions - Pinnacle 21
Rule CT0009 removed from latest config-send-3.0.xml - why? ... I get the following warning: "SD1054" - "Non-recommended variable length" for variables like ...
Read more >
Recommended Disk Combinations - Trend Micro
If the Bypass Preboot policy is set to Allow, Full Disk Encryption prompts for the removal of one system disk. Normal system disk....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found