Rule Change: Add option to allow empty while loops to no-empty

What rule do you want to change?

no-empty

What change to do you want to make?

Implement suggestions

How do you think the change should be implemented?

A new option

Example code

const foo = () => {
  console.log('Still going');
  return Math.random() > 0.5;
};

while(foo()) {}

What does the rule currently do for this code?

It generates an error because empty while loops are banned.

What will the rule do after it’s changed?

Generate an error based on if the allow-empy-while-loops option is enabled.

Participation

• I am willing to submit a pull request to implement this change.

Additional comments

This is useful when using Prettier because Prettier always formats empy while loops into empty blocks, which makes using Eslint and Prettier together really annoying because they can’t agree on what to do with empty while loops. Currently the only way to solve this is by turning of no-empty, which I think is unfortunate because it’s useful for catching other errors.

[amareshsm]

I am interested to work on this. can I pick this one? @Bwallker let me know if you are working on this.

[mdjermanovic]

Got it. Where we can see these suggestions? It is mentioned suggestions will be shown in the editor but I am not able to reproduce them. Can someone help me with this? I would like to see how suggestions will be shown to the users.

VS Code supports suggestions.

Rules marked with 💡 in the list of rules provide suggestions.

For example, if you have this code:

/* eslint no-useless-escape: "error" */

"\a"

\ will be underlined as an error. When you hover over it, VS Code will offer Quick Fix:

First two options (Remove the '\'..., and Replace the '\' with '\\'...) are suggestions provided by the no-useless-escape rule. When you click on a suggestion, it will fix the code.