Rule Change: prevent new-cap from flagging the caller because of third-party modules

What rule do you want to change?

new-cap

What change to do you want to make?

Generate fewer warnings

How do you think the change should be implemented?

A new default behavior

Example code

import { Deserialize } from 'cerialize';

// ...
const someObj = Deserialize(someJson, SomeType);

What does the rule currently do for this code?

Currently new-cap flags the code because Deserialize() is not camelCased, despite it being a third party module.

What will the rule do after it’s changed?

One of the followings:

1. Check the naming rule at the point of definition (callee), rather than at the point of invocation (caller).
2. Ignore ESM imported function calls from being checked.

Participation

• I am willing to submit a pull request to implement this change.

Additional comments

See #15722 for the previous Q&A.

[mdjermanovic]

I’d be a new option, as it’s also likely to be incorrect usage. e.g.

import { Foo } from "foo";

var foo = Foo(); // should be new Foo();

making it the default will ignore these errors?

I think this rule is intended to enforce naming conventions, not to catch errors (though, it can catch errors).

[nzakas]

Fair enough. Given that we don’t agree that this is a bug, we can close this.

@nedsociety it looks like you have some options to work around this limitation already.