Rule Change: Suggestions for prefer-regex-literals disallowRedundantWrapping option

What rule do you want to change?

prefer-regex-literals

What change to do you want to make?

Implement suggestions

How do you think the change should be implemented?

Other

Example code

/* eslint prefer-regex-literals: ["error", {"disallowRedundantWrapping": true}] */
const reg0 = new RegExp('a'); 
const reg1 = new RegExp(/a/);   // no suggestion
const reg2 = new RegExp(/a/, 'g'); // no suggestion

What does the rule currently do for this code?

The rule didn’t suggest for unnecessarily wrapped patterns which disallowed by "disallowRedundantWrapping": true. demo

What will the rule do after it’s changed?

It will make suggestions for the patterns also.

/* eslint prefer-regex-literals: ["error", {"disallowRedundantWrapping": true}] */
const reg1 = new RegExp(/a/);   //  =>  /a/
const reg2 = new RegExp(/a/, 'g'); // => /a/g
const reg3 = new RegExp(/a/g, 'i') // => /a/i

Participation

• I am willing to submit a pull request to implement this change.

Additional comments

No response

[mdjermanovic]

const reg1 = new RegExp(/a/);   //  =>  /a/
const reg2 = new RegExp(/a/, 'g'); // => /a/g

As for these two cases, perhaps the rule could autofix them instead of providing suggestions?

[mdjermanovic]

Yes, it would be the same behavior, but new RegExp(/a/g, 'i') looks like redundant wrapping + possible error. This is somewhat similar to the cases that no-useless-escape reports, where the rule always provides two suggestions. For example, for "\a" there’s a suggestion to fix to "a" (the same behavior) and a suggestion to fix to "\\a" (not the same behavior, but it’s very possible that this was the actual intent).