Rule idea: String call instead of template literal

Hi. I have an idea for the rule that will make reading the code more convenient. Instead of template literal with one value and without regular string around, String call looks more clearly.

Example of bad code:

// prefer-string-call: "error"
const stringCount = `${getCount()}`; // Expected call of String() instead of template literal

Example of good code:

// prefer-string-call: "error"
const stringCount = String(getCount);

[platinumazure]

Hi @krutoo, thanks for the issue.

Personally, this feels like a subjective preference and I could see people going either way on this. Also, this covers a pretty small subset of strings. So I’m mildly opposed to adding this to core, but I will go along with the team consensus.

It sounds like this would be a great case for a custom rule for your codebase.

[ljharb]

When template literals are available, nobody should be using String(), because global.String = function () { return 42; } will break that code.

The reason '' + foo is bad is because it calls valueOf first, not because it’s implicit (it’s not) - a template literal, like String(), calls toString first, which makes it the best approach hands down.

This rule should not exist, nor should it be an option on an existing rule.