Rule suggestion: disallow !a instanceof b

As the existing rule no-negated-in-lhs, it seems like it would be good to also disallow

if (!a instanceof b) // do something

since the developer certainly meant to write

if (!(a instanceof b)) // do something

instead. This prevents errors, and there’s no legitimate case for the former that I can think of, so I think this could be enabled by default as with no-negated-in-lhs. I’ve thrown together a quick copy and paste job of no-negated-in-lhs which works; will attach PR.

<bountysource-plugin>

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource. </bountysource-plugin>

[mysticatea]

@nzakas I think this is a rule to prevent enough common problem and this is accepted.

Accepted issues are good start points for new contributors, but until now, rule’s deprecation process is not clear; I guess it was a barrier to contributing to this issue. Just now, we are making some rules deprecated. I think we can go to advance this as well. (I can work on this later)

[nzakas]

For this, we are strictly talking about using ! with in and instanceof, though. I’m not sure it makes sense to extend the rule further than that.

I’m still thinking that no-unsafe-negation is clearest for this use case.