Rule tester output not applying all fixes

Tell us about your environment

• ESLint Version: 5.10.x
• Node Version: 6-11

While working with rules RuleTester is not applying all fixes, but CLI does.

In RuleTester we have something like this, it means that we are accessing SourceCodeFixer dirrectly instead of having similar logic to verifyAndFix from Linter

const fixResult = SourceCodeFixer.applyFixes(item.code, messages);
assert.strictEqual(fixResult.output, item.output, "Output is incorrect.");

Fixed output of tests is “processed” once instead of ‘less than 10 if there are still fixes to apply’

---

• Linter:verifyAndFix - https://github.com/eslint/eslint/blob/master/lib/linter.js#L1010
• RuleTester:testInvalidTemplate - https://github.com/eslint/eslint/blob/master/lib/testers/rule-tester.js#L567

[mysticatea]

The solution in your case would be to call context.report once per identifier change (so report 4 errors, not 2).

No. 😇 The fix of each error may be applied individually, so if it separated errors per identifier change, it may break code; an identifier was renamed but others were not renamed (it makes ReferenceErrors).

[g-plane]

I think we can keep fixing one report by default, but we can provide an option (maybe called applyAllFixes) to allow plugin developer to apply all fixes, which won’t bring breaking change.