Question: how come function references on the global scope are not closed
See original GitHub issueI’m working on trying to understand this codebase better. But I can’t understand why it works this way:
function a() {}
a();
To me it seems clear that the reference that’s created as part of the call should resolve directly to the function declaration, but it’s not - it remains as an unresolved reference that’s added to the global scope’s through
list.
This would cause the no-unused-vars
ESLint rule to error on the function declaration, were it not for this code in the linter.
It looks like it works seemingly by chance? ESLint augments the global scope with more variables, and then forcefully resolves any through
references against the global variable set
, which includes the function declaration as well as the augmented variables.
Is anyone able to explain why this works this way?
Or a better question - when closing the global scope, why doesn’t it attempt to resolve all through
references against the variables defined in the global scope?
Issue Analytics
- State:
- Created 3 years ago
- Comments:6 (4 by maintainers)
Top GitHub Comments
Thank you for your question.
…but, I’m not sure why it’s so. I guess that it’s as-is from the original package
escope
.Maybe… it couldn’t assume declarations in global scope make variables, because browsers may ignore declarations.
Yes,
data:text/html,<script type="module">var top = function(){}; top();</script>
works fine.Also, new
knownGlobals: string[]
option may be good to make variables and resolve references.