space-in-parens throws false positive inside if condition between closing parens

Tell us about your environment

• ESLint Version: 5.6.1
• Node Version: 8.11.4
• npm Version: 5.6.0

What parser (default, Babel-ESLint, etc.) are you using? Default

Please show your full configuration:

{
  "plugins": [
    "cypress",
    "chai-friendly"
  ],
  "env": {
    "cypress/globals": true
  },
  "extends": [
    "eslint:recommended",
    "standard"
  ],
  "parserOptions": {
    "ecmaVersion": 6,
    "sourceType": "module"
  },
  "globals": {
    "App": true
  },
  "rules": {
    "max-len": [
      "error", {
        "code": 80,
        "tabWidth": 2
      }
    ],
  "space-in-parens": ["error", "never", {
    "exceptions": ["()"]
    }],
  "no-unused-expressions": 0,
  "chai-friendly/no-unused-expressions": 2
  }
}

What did you do? Please include the actual source code causing the issue, as well as the command that you used to run ESLint.

Code which exhibits the bug:

const theTrueFunc = () => true

// this will complain that there is no space after the function call and the closing if bracket
if (theTrueFunc()) {
  console.log('True dat')
}

What did you expect to happen? Should not have to insert space after function

What actually happened? Please include the actual, raw output from ESLint.

/home/grayedfox/github/comgy/mh-tests/cypress/support/helpers.js
  8:32  error  There must be a space inside this paren  space-in-parens

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

[platinumazure]

Hi @GrayedFox, thanks for the issue.

I’ve just read the docs, and I think the key point is that any tokens listed in the rule’s exceptions option must completely surround the expression.

Some examples:

/* eslint space-in-parens: ["error", "always", { "exceptions": ["()"] }] */

// Allowed:
foo(( 5*2 ));    // The outer parentheses don't need spaces just inside them.
                 // Subexpression is completely surrounded by parentheses.
                 // Inner parentheses need spaces because the expression within does not have parens.

// Not allowed:

foo(5 * (2+3));  // Whole expression is not surrounded by parentheses
                 // Expected: foo( 5 * ( 2 + 3 ) );

foo(someFunc());  // Whole expression is not surrounded by parentheses
                  // Expected: foo( someFunc() );

If you think the documentation could be improved, we would welcome a pull request!

[eslint-deprecated[bot]]

Unfortunately, it looks like there wasn’t enough interest from the team or community to implement this change. While we wish we’d be able to accommodate everyone’s requests, we do need to prioritize. We’ve found that issues failing to reach accepted status after 21 days tend to never be accepted, and as such, we close those issues. This doesn’t mean the idea isn’t interesting or useful, just that it’s not something the team can commit to.

Thanks for contributing to ESLint and we appreciate your understanding.