The `no-magic-numbers` rule should ignore function calls

Usually when one number is used with a function the intent is clear and I wouldn’t consider that a magic number. Currently this rule is unusable for me as it gives too many false positives.

In my tests I use a t.plan() method to plan how many assertion the test will have. I have a lot of the following, so my tests gets an endless amount of no-magic-number violations:

test('foo', function (t) {
  t.plan(2);
  ...
});

~/dev
❯ eslint --version
v1.7.3

~/dev
❯ echo 't.plan(2)' | eslint --stdin --rule='no-magic-numbers: [2, {ignore: []}]'

<text>
  1:8  error  No magic number: 2  no-magic-numbers

✖ 1 problem (1 error, 0 warnings)

The rule should either ignore function calls by default or have an option for doing so.

<bountysource-plugin>

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource. </bountysource-plugin>

[nzakas]

Can you explain why you think function calls should be an exception?

[nzakas]

Seems like we couldn’t resolve this, and no further interest or discussion occurred in the past few months, so closing.