v3.6 ignores "smart-tabs" rule and notifies of indent errors

I’m a maintainer of Leaflet, and we use an eslint config with smart-tabs, like:

      "no-mixed-spaces-and-tabs": [2, "smart-tabs"],
      "indent": ["error", "tab", {"VariableDeclarator": 0}],

eslint 3.0 through 3.5 work just fine. However, after an upgrade to eslint 3.6, we’ve got error messages like the following:

/home/ivan/devel/Leaflet/src/control/Control.js
   64:7  error  Expected indentation of 2 tabs but found 4 spaces and 2 tabs  indent

This can be reproduced by checking out the Leaflet repo, then running npm install and then npm test. Note that running npm install eslint@3.5 then npm test will work as expected.

We don’t use any transpiler in the Leaflet toolchain; full eslint config is available on the Leaflet repo; and the bug is reproducible on the environments of more than one developer.

Looking at eslint’s changelog, I’ll guess that this is caused by #7076 (ping @not-an-aardvark)

[nzakas]

Ah yes, looked at this too quickly, you’re right. I’ll look at reverting that for now and we can revisit whether or not there should be two rules at a later point.

[not-an-aardvark]

If someone can make the correct fix, that’s fine, but if no one has the time to do that today, then we should revert the commit to do a patch release.

I made a PR to fix the issue at https://github.com/eslint/eslint/pull/7266.

This is also a good reminder to make sure each PR solves only one problem so that reverts are clean.

Fair enough, will keep that in mind for future PRs.