[Bug Report]: Build status notification doesn't disappear when build fails (VSC-540)
See original GitHub issuePre Bug Report Checklist Before reporting any bug please make sure of these points.
- Make sure you have searched for existing bugs and features request before you post an issue.
- This is a bug report for the ESP-IDF Visual Studio Code extension and not an ESP-IDF bug report.
- I’ve read the docs and found no information that could have helped solving the issue.
Describe the bug A build failure results in the build progress notification at the bottom right staying visible and stuck at whatever point the build fails at. This also means subsequent builds require you to click cancel, otherwise the error “Wait for ESP-IDF build or flash to finish” shows. Clicking cancel also closes the active terminal so you can’t see the build log and its reason for failure.
To Reproduce Cause a build error by trying to compile invalid C.
Expected behavior A build failed notification to be displayed and the build progress notification to disappear, also the current terminal/build log to be preserved.
Screenshots If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):
- OS Name & Version: macOS 11.0.1
- VSCode Version: 1.52.1
- ESP-IDF Version: 0.6.0
- Python Version: 3.9.0
Logs esp_idf_vsc_ext.log
Extension Configuration settings
Open Command Palette (F1) and type Preferences: Open Settings (JSON)
or use {CURRENT_PROJECT}/.vscode/settings.json
to get the following extension configuration settings value:
idf.espIdfPath
: /Users/elijah/Scratch/esp-idfidf.pythonBinPath
: /Users/elijah/.espressif/python_env/idf4.2_py3.9_env/bin/python3idf.openOcdConfigs
: board/esp32-wrover-kit-1.8vidf.customExtraPaths
: /Users/elijah/.espressif/tools/xtensa-esp32-elf/esp-2020r3-8.4.0/xtensa-esp32-elf/bin:/Users/elijah/.espressif/tools/xtensa-esp32s2-elf/esp-2020r3-8.4.0/xtensa-esp32s2-elf/bin:/Users/elijah/.espressif/tools/esp32ulp-elf/2.28.51-esp-20191205/esp32ulp-elf-binutils/bin:/Users/elijah/.espressif/tools/esp32s2ulp-elf/2.28.51-esp-20191205/esp32s2ulp-elf-binutils/bin:/Users/elijah/.espressif/tools/openocd-esp32/v0.10.0-esp32-20200709/openocd-esp32/bin"idf.customExtraVars
: {"OPENOCD_SCRIPTS":"/Users/elijah/.espressif/tools/openocd-esp32/v0.10.0-esp32-20200709/openocd-esp32/share/openocd/scripts"}idf.adapterTargetName
esp32
Additional context The previous version of the extension worked fine!
Issue Analytics
- State:
- Created 3 years ago
- Comments:15
Top GitHub Comments
Sorry @brianignacio5 I didn’t have notifications on! I did have an
idf.customExtraPaths
and ended up deleting the .vscode/settings.json to fix it, and re-running Onboarding. Seems there must have been a duplicate, incorrect path somehow. Maybe one time I ran onboarding I chose to save the config in the wrong place. Thanks for your help! 😃Reporting the same behavior here. VS Code build doesn’t seem to end on build failures.
I have to manually close the build task, and only then VS Code is able to show errors. In my case, there’s no version issue.