layer.query() with Geometry filters returns incomplete results.

Running a layer.query() with a Geometry filter returns only some of the expected records.

To Reproduce Query a layer using a Geometry filter:

import arcgis

# Polylines
GEOM = {"paths":[[[265091.207,6637610.73],[265066.57,6637626.64],[265058.70,6637658.92],[265051.398,6637692.902],[265048.31,6637728.14],[265045.603,6637765.623]],
[[265126.08,6637725.828],[265133.88,6637735.42],[265127.43,6637771.09]]],"spatialReference":{"wkid":25833,"latestWkid":25833}}

_gis = arcgis.GIS('pro')
_parcels = arcgis.gis.Item(_gis, '577566e7970e4f9fa53f1afb58c43178')
_myfilter = arcgis.geometry.filters.intersects(GEOM)
_res = _parcels.layers[0].query(
    geometry_filter=_myfilter,
    out_fields="kommunenr,gardsnr,bruksnr",
    geometry_precision=2,
    distance=5,
    units="esriSRUnit_Meter")

print(len(_res))

The problem seems to be that the API does a recordcount and uses it to set max_records in the query. After changing from record_count to max_records at line 1795 in features/layer.py all intersecting parcels are returned from the service.

Expected behavior All intersecting parcels should be returned in the result.

Platform (please complete the following information):

• Python API Version: 1.9.1
• AGE Enterprise 10.8.1

[HakonD]

The bug also applies to API 2.0.0

[HakonD]

@achapkowski Still, as long as this server side bug exists I will argue that the Python API should not add a feature count parameter when there are a spatial filter, or at least you should not override the result_record_count set by the user if any.