Unable to favorite any Living Atlas item as an organization administrator using shareItemWithGroup

Issue description

I, as an org admin, am unable to favorite a Living Atlas item (Owned by a user outside of my organization) to my favorite’s group.

Context

Since https://github.com/Esri/arcgis-rest-js/commit/e8ab1bc3ad4498e5c1ac19fc0f1c24013de0a8df, the shareItemWithGroup now handles a different API route to share an item to a group if the sharing was performed by an org_admin. This route uses the /content/users/:ownername/items/:itemid/share which when favoriting a Living Atlas item, does not have the right permissions to add to favorite group since the item and the user don’t belong to the same organization as the org admin and therefore no item control.

Steps to reproduce

1. Use the following inputs to run the shareItemWithGroup function: A. id: bf7c462f912f4d41ba262ba3c0e9008f B. groupId: “Org admin favorite group ID” C. owner: “cfrye_UO” D. authentication: Org admin user session

Seen behavior

I get an error that I do not have permissions to favorite the item.

Expected behavior

I would expect that an admin is able to favorite a Living Atlas item just like any other member of the organization.

Version

Browser: Chrome, Firefox, Safari (all OS) ArcGIS-Rest-Js: v3.2.0

Use case

The ArcGIS StoryMaps app offers several item browser views in its ecosystem. There’s a browser to explore and search for Living Atlas web maps, scenes, storymaps, apps and files. This browser view can be accessed by both an admin and any non-admin user.

We’re running into this issue specifically for the org_admin use case.

[dbouwman]

@tonybattsesri - We have confirmed that there is an issue that’s connected to situations involving sharing an item to a group across org’s, which is further compounded with org_admin users.

We are investigating how resolve this “correctly” without breaking other needed behaviors.

[patrickarlt]

@dbouwman @tomwayson can you take a look?