setWhere callback is not called

Changing the where condition on a newly created layer doesn’t let the callback to be executed.

var layer = L.esri.featureLayer({
    url: "link",
    where: "1=1",
});
layer.addTo(map);
layer.setWhere("1=2", function(){
    console.log("callback called");
});

The callback is correctly executed if the setWhere is executed after a few seconds.

[jwasilgeo]

I’ve been able to see this happening, too, at esri-leaflet v2.2.3, described more or less the by the title of #780. One way to repro (and thanks for the idea, @gavinr) is to slow down network traffic speeds with the browser dev tools.

1. Navigate to this sample page: https://esri.github.io/esri-leaflet/examples/querying-feature-layers-1.html
2. Dev tools --> network tab --> throttle to a slower speed
3. Refresh the sample page
4. Choose a new bus direction where clause filter as soon as you can and before the feature layer is fully loaded and ready
5. Although it may be hard to see with point icon markers, the state of the layer is a bit off and you may see both all (1=1) and the filtered subset of features

[jwasilgeo]

I think this had to do with network request race conditions prior to v2.4.0. Let’s be sure to look at this issue while investigating #1196.