Client interfaces

I’m wondering if it could make sense to enhance client interface with convenient methods i.e:

• Options should not be mandatory:

ListenableFuture<PutResponse> put(ByteString key, ByteString value);

• Leverage java 8 functional interfaces (if project will be moved to java 8 of course):

void put(
   ByteString key, ByteString value, 
   PutOption option, 
   Consumer<PutResponse> onResponse, Consumer<Throwable> onError);

void put(
   ByteString key, ByteString value, 
   Consumer<PutResponse> onResponse, Consumer<Throwable> onError);

void put(
   ByteString key, ByteString value, 
   Consumer<PutResponse> onResponse); throws an RuntimeException in case of error

[jurmous]

My preference would be to return java 8 CompletableFuture on any of those put calls. It seems to be the route for futures/listeners in java going forward. You would then be able to do this:

future.handle((ok, ex) -> {
    if (ok != null) {
        // handle ok
    } else {
        // handle exception
    }
});

or just future.get() for sync call and throws ExecutionException

More: http://www.nurkiewicz.com/2013/05/java-8-definitive-guide-to.html http://download.java.net/lambda/b88/docs/api/java/util/concurrent/CompletableFuture.html

[oza]

FYI, as I mentioned here, I think we should avoid exposing ByteString as a part of API generated by protobuf directly.