When Token is invalid the watcher will be hung there

jetcd 0.4.1

1、For normal request , like kv.get

when token is invalid, the flow will enter

io.grpc.ForwardingClientCallListener.SimpleForwardingClientCallListener#onClose

super.start(new SimpleForwardingClientCallListener<RespT>(responseListener) {
            @Override
            public void onClose(Status status, Metadata trailers) {
              if (isInvalidTokenError(status)) {
                try {
                  refreshToken(next);
                } catch (Exception e) {
                  // don't throw any error here.
                  // rpc will retry on expired auth token.
                }
              }
              super.onClose(status, trailers);
            }
          }, headers);

2、for watch request

when token is invalid, the flow will never enter “onClose” to “refreshToken”

it will receive a normal message “Permission Deny”,

io.etcd.jetcd.WatchImpl.WatcherImpl#onNext process the message and return normal. it will not try again.

 if (response.getWatchId() == -1) {
          listener.onError(newEtcdException(ErrorCode.INTERNAL, "etcd server failed to create watch id"));
          return;
        }

There is no chance for watcher to refresh Token,. the watcher is hanging there…

[lukasz-antoniak]

Figured out the issue. Watcher hangs when token is invalid and we try to register new watch. I will try to fix it and open new PR.

[lburgazzoli]

Fixed by #729