Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

regression on 'getHTML' backend test

See original GitHub issue

PR #3268 caused a regression on the ‘getHTML’ backend test.

Expected:

<!doctype html><html><body><ul class="bullet"><li>one</li><li>2</li></ul><br><ul><ul class="bullet"><li>ul2</li></ul></ul></body></html>

Received:

<!doctype html><html><body><ul class="bullet"><li>one</li><li>2</ul><br><ul class="bullet"><li><ul class="bullet"><li>ul2</ul></li></ul></body></html>

The regression bisects to PR 3268, that changes src/node/utils/ExportHtml.js.

Steps to reproduce:

clean up the installation: rm -rf node_modules src/node_modules
update to revision bacc37cf9b3a (the last one before merging the PR)
start Etherpad with bin/run.sh
in another console, start bin/backendTests.sh (the whole test suite takes ~2 seconds to run)
the tests will pass
stop Etherpad
update to revision fe08d2a1db5b (the one that merged the PR)
start Etherpad with bin/run.sh
in another console, start bin/backendTests.sh
the test will not pass
if you also want to see the wrong output given above, perform the same test on revision f2b5f3bca2bb, which introduces an explicit error message

@ilmartyrk could you have a look?

Issue Analytics

State:
Created 5 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

ilmartyrkcommented, Jul 17, 2018

@muxator I’ll have to agree with you.

During my time being involved with EP project I have found many places where code is written not following standards etc. For example many plugins that use buttons have hard coded html insertions instead of using register button/method functionalities, but yes that doesn’t mean it is acceptable.
I’ll write new test. Not sure how yet, but I’ll try to make something acceptable

0reactions

muxatorcommented, Aug 7, 2018

Update: discussion on this is currently taking place in https://github.com/ether/etherpad-lite/pull/3268#issuecomment-410847213 and subsequent comments. It should probably be moved here.

Top Results From Across the Web

What is Regression Testing? Test Cases (Example) - Guru99

Regression Testing means to confirm that a recent program or code change has not adversely affected existing features. In this tutorial ...

B Testing with Jest | Client-Side Web Development

This chapter introduces automated testing using the Jest framework. By following this tutorial, you will learn how to write and execute simple unit...

Guide to Python Flask Unit Testing - Code The Change Stanford

Unit Testing: Tests small components of the program (units) in isolation. For example, you might test each individual function. Integration Testing: Tests ......

Automated Regression Testing for Backend UI

Automated regression testing solution to speed up the regression testing execution time - scalable and fully integrated.

Autopsy: Regression Testing - The Sleuth Kit

adding an image; configuring ingest; running ingest; generating an HTML report. The tests can be invoked using ant regression-test. There is a python...