question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

RFE: Dockerfile to build from working directory

See original GitHub issue

Currently, the Dockerfile builds the Docker image after pulling the Etherpad codebase from Github:

https://github.com/ether/etherpad-lite/blob/801d519165ef64bf5424ac395abfc838fa25ba9d/docker/Dockerfile#L28-L42


I would find more convenient (and less surprising) if the Dockerfile built the Docker image from the code checked out in the local filesystem.

In practice, I suggest replacing the curl call with (I simplify):

COPY ./ ./

Accidentally, this change would enable testing the Docker image as part of the CI jobs.


What do you think?

cc @muxator

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
muxatorcommented, Nov 14, 2019

I had a hard time force pushing on https://github.com/pierreprinetti/etherpad/tree/local_dockerfile in order to bring #3662 in (my bad).

Directly implemented the rewritten version in dc15f4a43c0e. Closing this.

1reaction
muxatorcommented, Nov 8, 2019

I think I forgot to click a green button 😃 See if you see them now!

Read more comments on GitHub >

github_iconTop Results From Across the Web

RFE: dockerfile secret #1684 - containers/buildah - GitHub
Strange looking at this command line. docker build --no-cache --progress=plain --secret "id=gpg,src=$GPGKEY" -t tmp$$:1 . "$@ ...
Read more >
Dockerfile reference - Docker Documentation
Docker can build images automatically by reading the instructions from a Dockerfile . A Dockerfile is a text document that contains all the...
Read more >
RFE: Add support to build CDT projects in a Docker Container
User uses a special Build Settings page to select a Docker image to use for the current configuration. Indexing is supported by copying...
Read more >
Build an Image - Specify Dockerfile Location · Codefresh | Docs
You could also change the Docker build context by editing the working_directory property. By default it is looking at the root folder of...
Read more >
What is "/app" working directory for a Dockerfile?
There are two important directories when building a docker image: the build context directory. the WORKDIR directory.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found