Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Move casper contract to use custom units

See original GitHub issue

Hi There!

So we recently introduced custom units into vyper with VIP 752. Quick example of usage https://vyper.readthedocs.io/en/latest/types.html#custom-unit-types.

What I would like to probe - if there is perhaps reason we can remove some of the current static unit types from vyper completely.

m
currency_value
currency1_value
currency2_value

I feel like these are quite opaque and will cause trouble for future users of vyper. Additionally because we force a description field on custom units, future users will be able to understand the units much better.

What is everyone’s thoughts on this? If there is consensus in agreement with the above proposal, I will create a VIP to remove the not-obvious static units from vyper.

Issue Analytics

State:
Created 5 years ago
Comments:11 (9 by maintainers)

Top GitHub Comments

3reactions

djrtwocommented, May 11, 2018

I support this.

That said, I haven’t been able to figure out a good custom unit for casper’s scaled deposits. I guess maybe just scale_factor – wei / scale_factor. Don’t want to hijack this thread, but open to ideas.

ps, thank you for your continued rapid development of Vyper. It’s exciting to see all the features/syntax tighten up.

1reaction

djrtwocommented, May 25, 2018

This is unblocked. Need to decide on our units now…