question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

After Byzantium, stop calculating state root after each transaction at all

See original GitHub issue

What is wrong?

Persisting all account changes to the trie and calculating the new state root is expensive. After Byzantium, we no longer need to calculate the state root after each transaction (because it has been removed from the receipt).

How can it be fixed

Stop returning state root after every apply_transaction(), instead generating it only if the receipt requires it.

(Depends on PR #704 )

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
cburgdorfcommented, Jun 18, 2019

Looks like this can be closed (#1716 solved this)

0reactions
rayrapetyancommented, Jan 15, 2019

Looks like if we just stop calling make_state_root (and all kind of persist\commit) inside apply_transaction, we reach our goal. Using existing Journals we can rollback\commit whenever we need.

Read more comments on GitHub >

github_iconTop Results From Across the Web

The Byzantine Agreement Problem: Optimal Early Stopping
early stopped processor cannot determine when all. other processors will stop. In the worst case, agree-. ment will be achieved after the maximum...
Read more >
Chapter 14: Consensus and Agreement
Byzantine Agreement (single source has an initial value). Agreement: All non-faulty processes must agree on the same value. Validity: If the source process ......
Read more >
Guided practice: continuity and change in the Byzantine Empire
The Byzantine Empire lasted for a millennium after the fall of the Roman Empire, ending with the Ottoman conquests in 1453. While the...
Read more >
Megali Idea - Wikipedia
The Megali Idea is a nationalist and irredentist concept that expresses the goal of reviving the Byzantine Empire, by establishing a Greek state,...
Read more >
Method for distributed transaction commit and recovery using ...
ABSTRACT: This paper describes an application of Byzantine Agreement [DoSt82a, DoSt82e, LyFF82] to distributed transaction commit.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found