Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Changes to `Chain.import_block`
See original GitHub issueBlocks: https://github.com/ethereum/py-evm/issues/733
What is wrong?
Currently chain.import_block(..) returns the block that was imported. Sometimes, this will cause a chain re-org, but this API doesn’t expose sufficient information to determine this.
How can it be fixed
Change Chain.import_block to return two iterables:
- blocks which are new to the canonical chain.
- blocks which were previously part of the canonical chain (but no longer are).
With this, callers can inspect the return value and determine that a re-org happened when more than a single block is returned.
This will also require changing ChainDB.persist_block to return the same data format, an iterable of blocks which are part of the new canonical chain.
Issue Analytics
- State:
- Created 5 years ago
- Comments:9 (9 by maintainers)
Top Results From Across the Web
Top Related Medium Post
Top Related StackOverflow Question
Troubleshoot Live Code
Top Related Reddit Thread
Top Related Hackernoon Post
Top Related Tweet
Top Related Dev.to Post
Top Related Hashnode Post
Already confirmed with @voith that I will take on this task 🍴
With HeaderDB, we ended up also returning a list of dropped headers on re-org, right? That might make sense here, too.