question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Check if we can initialize the PeerPool earlier

See original GitHub issue

What is wrong?

This is a follow up to the discussion @pipermerriam and I had here.

Currently the PeerPool isn’t available until some other async tasks are resolved. This issue serves as a reminder to check whether the PeerPool could be created synchronously earlier.

How can it be fixed

A possible idea would be to create the PeerPool early on without the dependencies that first need to be resolved asynchronously and then as a second step, once these dependencies are resolved, call some initialization API on the PeerPool. Before that, the PeerPool would already exist but would reside in some sort of bootstrapping mode until that API is called.

Not sure, if I like that tbh. ¯_(ツ)_/¯

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

2reactions
gsalgadocommented, Jun 6, 2018

ISTM that the problem here is the fact that Server.peer_pool only gets set in Server._run() and not in Server.__init__(), as it should. IIUC we do that because of some (far from ideal) server or sharding tests. If we fix those tests we could then initiate a PeerPool and assign it to Server.peer_pool in Server.__init__(), as I think we should do

0reactions
cburgdorfcommented, Jun 21, 2018

Solved problem. Closing.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Minimal testnet for sharding · Issue #419 · ethereum/py-evm · GitHub
From what I can tell the reader/writer pair can then be used to initialize a Peer instance. What I'm not sure of is...
Read more >
ethereum/py-evm - Gitter
Is it possible to initialize PyEVM with a different GENESIS_GAS_LIMIT? I'm using PyEVM for some contract testing with web3.py and I'm finding that...
Read more >
Configuring and Managing External Modems [Support] - Cisco
This section describes how to determine and issue the correct initialization string for your modem and how to configure your modem with it....
Read more >
IPFS CLI Setup | Documentation - Media Network
Before using IPFS for the first time, you'll need to initialize the repository with the ipfs init command: If you are running on...
Read more >
BIG-IP Service Provider: SIP Administration - F5 Networks
Create deny listeners to drop media packets received before the callee ... All virtuals that needs to work together as one router-instance ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found