Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Make fix-unclean-shutdown a Plugin

See original GitHub issue

What is wrong?

Currently, the fix-unclean-shutdown command is implemented directly in the main trinity code base. This could easily live under trinity/plugins similar to how the trinity attach command is handled.

How can it be fixed

Move code and wrap a plugin around it.

Issue Analytics

State:
Created 5 years ago
Comments:8 (5 by maintainers)

Top GitHub Comments

1reaction

timfong1015commented, Jul 26, 2018

@cburgdorf Thanks, I am drilling into this now and will let you know if I need more assistance.

0reactions

cburgdorfcommented, Aug 14, 2018

@timfong1015 I cleaned that one up https://github.com/ethereum/py-evm/pull/1182

Feel free to checkout other issues that are flagged as “Good First Issue” (but feel free to also check out any other issues!)

https://github.com/ethereum/py-evm/issues?q=is%3Aissue+is%3Aopen+label%3A"Good+First+Issue"

Top Results From Across the Web

`ethstats` plugin for node status reporting · Issue #1187 - GitHub

PR Convert "fix-unclean-shutdown" to plugin #1182 (merged) ... as we need to make changes to our architecture to enable plugins like this.

Natty (11.04) - Ubuntu - Launchpad Code

Name Status Last Modified lp:ubuntu/natty‑proposed/landscape‑client Mature 2014‑11‑19 18:20:33 UTC 2014‑11‑19 lp:ubuntu/natty‑proposed/emerald Mature 2014‑01‑20 13:07:59 UTC 2014‑01‑20 lp:ubuntu/natty/zope.testing Mature 2013‑12‑13 08:09:22 UTC 2013‑12‑13

PostgreSQL 13 Beta 1 New Features With Examples (EN) - HPE

execute the CREATE EXTENSION statement even if the user does not have the ... --no-ensure-shutdown do not automatically fix unclean shutdown.

other.xml.gz - Linux @ CERN

Nothing client-side can make use of this anyway so enabling has no drawbacks but aligns ... Resolves: bug#1191313 - Do not build yum-plugin-downloadonly....

Release Notes — trinity 0.1.0-alpha.37 documentation

Obtaining the full state is the best way to make sure that your node cannot be knocked ... #1182: Convert fix-unclean-shutdown CLI command...