dist/hdkey.js (Maintainer Update: Critical bug in v0.6.1, now fixed with v0.6.2, please update!)

With the new 0.6.1 release, this:

const hdkey = require('ethereumjs-wallet/hdkey');

Must be changed to:

const hdkey = require('ethereumjs-wallet/dist/hdkey');

Maybe that’s not what you intended? Even though your pkg.json main points at dist/, a module reference like 'ethereumjs-wallet/hdkey' only works if hdkey.js is at the top-level of the package.

In the published package, you could include an hdkey.js that’s a one-liner:

module.exports = require('./dist/hdkey.js');

However, you would need to reorg the sources that get transpiled by babel under src/ and update the build:dist script accordingly.

[sohkai]

@axic @holgerd77 If a fix will be longer than a few days, it might be better to republish 0.6.0 as 0.6.2. This dependency breaking has been impacting a lot of packages.

[holgerd77]

My current impulse is to put the original sources in a folder src/ and then transpile to the root directory and do a PR on this, I think there are not too many paths to be changed in this regard, and then release as v0.6.2.

Anything speaking against this solution?