Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

v1.0.0 Release planning

See original GitHub issue

The v1.0.0 version of the library will be released soon, this mainly builds upon the TypeScript rewrite done by @the-jackalope in https://github.com/ethereumjs/ethereumjs-wallet/pull/93.

Testing of the current master branch of the library is encouraged, please also note if you have suggestions for the release.

TODOs:

Integrate to-be-released ethereumjs-util v7.0.0 version mainly based on the work done here https://github.com/ethereumjs/ethereumjs-util/pull/228 from @cgewecke
Wait for new hdkey dependency release (see comment below) to have a secp256k1 dependencies on v4, release is promised over on the library 😄
Remove ProviderEngine (needs discussion) https://github.com/ethereumjs/ethereumjs-wallet/issues/115
Update to patched ethereumjs-util v7.0.2 release (BN.js v5/v4 interoperability issue)
Optional: add CHANGELOG entry from v0.6.4 release (on its own v0.6.x branch)
Optional: give dependencies and devDependencies another look, some more explicit TypeScript version update (currently ^3.2.2)

Issue Analytics

State:
Created 3 years ago
Comments:6 (6 by maintainers)

Top GitHub Comments

1reaction

holgerd77commented, Apr 25, 2020

@kumavis have added you, please just don’t do but communicate on what you are doing and planning frequently, thanks 🙂

1reaction

kumaviscommented, Apr 25, 2020

@holgerd77 im interested in a 0.6.x patch with node v12 support trying to identify a last-good commit for the 0.6.x version range https://github.com/ethereumjs/ethereumjs-wallet/commits/master can you help me identify the first breaking change commit? changelog did not mention anything https://github.com/ethereumjs/ethereumjs-wallet/blob/master/CHANGELOG.md

maybe https://github.com/ethereumjs/ethereumjs-wallet/commit/695da18e4418261a86e22e28199089056fdfe599? so then changes since 0.6.3 up to that commit look like this: https://github.com/ethereumjs/ethereumjs-wallet/compare/e68a04290b6020c7d08d9f1e608df681bc75424d...c04b80e2b17e6f69171bb4ebd808d264737223fe#diff-c3b38b2d667a547e86b34134c77ff6f9 seems pretty safe. I’ll cut a branch and cherry-pick the scrypt fix