Allow binary message for wallet.signMessage.

hello @ricmoo , what is the equivalent of web.eth.sign() (https://github.com/ethereum/wiki/wiki/JavaScript-API#web3ethsign) in ethers.js ? I am trying to sign a piece of data in order to retrieve s, r and v from the signature. I tried with Wallet.sign() and also SigningKey.signDigest, but I don’t get the same output as when I call web3.eth.sign().

The purpose of that is that I need to call the solidity ecrecover function to verify that my address has signed the data.

Thanks a lot!

[ricmoo]

Ok, I’ve found the problem.

I have updated the signMessage API to allow binary data to be passed in. Before it only allowed UTF-8 strings. You will have to make a small change to the above code, since “0x1234” is a valid string (of 6 bytes); the eth-sig-util is using the message as a binary payload.

var hash = "0x47173285a8d7341e5e972fc677286384f802f8ef42a5ec5f03bbfa254cb01fad"

// To use the 66 byte string (not what you want)
wallet.signMessage(hash);

// To use the 32 byte binary data (matches the above eth-sig-util)
var hashData = ethers.utils.arrayify(hash);
wallet.signMessage(hashData);

I’ve also added your example to the test-cases.

Once Travis-CI has completed, I’ll publish to npm and close this issue. You’ll have to delete your package-lock.json and node_modules and redo an npm install, but then you should be off to the races. 😃

[ricmoo]

Excellent Point! I will add it to my todo list for the Cookbook.