ethers and rollup

Hey, I want to use ethers (v5) in a rollup based web app and I am hitting a few warning and I am not sure if there are issues :

(!) Missing shims for Node.js built-ins
Creating a browser bundle that depends on 'http', 'https' and 'url'. You might need to include https://www.npmjs.com/package/rollup-plugin-node-builtins
LiveReload enabled
(!) `this` has been rewritten to `undefined`
https://rollupjs.org/guide/en/#error-this-is-undefined
node_modules\@ethersproject\contracts\lib.esm\index.js
1: "use strict";
2: var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
                    ^
3:     function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
4:     return new (P || (P = Promise))(function (resolve, reject) {
...and 1 other occurrence
node_modules\@ethersproject\providers\lib.esm\base-provider.js
1: "use strict";
2: var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
                    ^
3:     function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
4:     return new (P || (P = Promise))(function (resolve, reject) {
...and 1 other occurrence
node_modules\@ethersproject\providers\lib.esm\cloudflare-provider.js
1: "use strict";
2: var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
                    ^
3:     function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
4:     return new (P || (P = Promise))(function (resolve, reject) {
...and 1 other occurrence

...and 10 other files
(!) Unresolved dependencies
https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency
http (imported by node_modules\@ethersproject\web\lib.esm\geturl.js)
url (imported by node_modules\@ethersproject\web\lib.esm\geturl.js)
https (imported by node_modules\@ethersproject\web\lib.esm\geturl.js)
(!) Missing global variable names
Use output.globals to specify browser global variable names corresponding to external modules
http (guessing 'http')
https (guessing 'https')
url (guessing 'url$1')
created dist\build\bundle.js in 6.5s

When I use rollup-plugin-node-builtins in an attempt to fix the warning about http/https/url

I get the following error :

[!] Error: 'URL' is not exported by node_modules\rollup-plugin-node-builtins\src\es6\url.js, imported by node_modules\@ethersproject\web\lib.esm\geturl.js
https://rollupjs.org/guide/en/#error-name-is-not-exported-by-module
node_modules\@ethersproject\web\lib.esm\geturl.js (13:9)
11: import http from "http";
12: import https from "https";
13: import { URL } from "url";
             ^
14: import { Logger } from "@ethersproject/logger";
15: import { version } from "./_version";
Error: 'URL' is not exported by node_modules\rollup-plugin-node-builtins\src\es6\url.js, imported by node_modules\@ethersproject\web\lib.esm\geturl.js

Any idea?

[samsends]

Hey @wighawag would you mind sharing your rollup config? Also trying to use rollup

[wighawag]

Cool, that was the mainFields thing, thanks!