EventFilter type doesn't have fromBlock and toBlock fields, even though those are processed and necessary

Using this filter:

const filter = myContract.filters.MyEvent();
const events = await myProvider.getLogs(filter);

I only get the latest event, but if I do this…

const filter = myContract.filters.MyEvent() as any;
filter.fromBlock = 0;
filter.toBlock = "latest";
const events = await myProvider.getLogs(filter);

I correctly get all events.

The cast to any is necessary because the type EventFilter doesn’t have fromBlock and toBlock fields.

Unless I’m misunderstanding something, this seems wrong.

[ricmoo]

@felixwatts Heya! Sorry for the late reply.

Those docs are out of date, and I will get redirects configured for them this week. The docs you are looking for are here: https://docs.ethers.io/v5/api/contract/contract/#Contract-queryFilter

Thanks @zemse !

[zemse]

const filter = myContract.filters.MyEvent();
const events = await myContract.queryFilter(filter);

This should work. And about the provider.getLogs, I wanted to bring that up before, but I forgot.

> provider.getLogs(filter);
[]

It returns empty array instead of error. I unfortunately ran into this when I was demonstrating in an event 😜 and needed to look at old working code. I suggest that if fromBlock and toBlock is not passed then it should fill in the blanks. filter.fromBlock = 0; filter.toBlock = "latest"; or at least give an error that this key wasn’t passed.

Edit: I see that typescript might point that out, but the JS should also do that (I actually demo in browser console using the exposed window._ethers).