FallbackProvider not catch detectNetwork error

Ethers Version

5.6.0

Search Terms

No response

Describe the Problem

the issue is regarding the fallback-provider. i have 3 providers configured and the quorum is set to 1. However, the query request (such as getBalance) will fail with only 1 JsonRpcProvider malfunction. As the quorum is set to 1, that’s not expected to happen.

After digging into the source code, i find the detectNetwork function is not catching the no network error. i have made changes to the original source code, and then my test passed.

below is the new code

  async detectNetwork(): Promise<Network> {
    const networks = await Promise.all(
      this.providerConfigs.map(async (c) => {
        try {
          return c.provider.getNetwork();
        } catch (error) {
          return null;
        }
      }),
    );
    return checkNetworks(networks as Array<Network>);
  }

also in checkNetworks, the check should continue in the for loop when no network is provided

   if (network == null) {
      continue;
    }

Code Snippet

the way i initiated a FallbackProvider


new FallbackProvider(
      [
        {
          provider: new ethers.providers.JsonRpcProvider(url1), 
          priority: 3,
          stallTimeout: 200,
          weight: 1,
        },
        {
          provider: new ethers.providers.JsonRpcProvider(url2), 
          priority: 1,
          stallTimeout: 200,
          weight: 1,
        },
        {
          provider: new ethers.providers.JsonRpcProvider(url3), 
          priority: 2,
          stallTimeout: 200,
          weight: 1,
        },
      ],
      1,
    );

Contract ABI

No response

Errors

No response

Environment

node.js (v12 or newer)

Environment (Other)

No response

[samholmes]

@cliff0412 A PR would be super helpful IMO. I wouldn’t ask permission, but rather just contribute the PR and let the maintainers decide whether it’s worth including.

Do you have a link to your fork so I may evaluate your code-changes and fork from your fixed state until the change moves upstream?

[cliff0412]

@ricmoo i have forked and made a pr. pls refer to https://github.com/ethers-io/ethers.js/pull/3247