function overriding error

G’day, mates!

While I’m testing Strings.sol library, I got an error with TypeError: uniqueNames[name_1].push is not a function.

contracts

library Strings {
    function toString(uint256 value) public pure returns (string memory) {
        if (value == 0) {
            return "0";
        }
        uint256 temp = value;
        uint256 digits;
        while (temp != 0) {
            digits++;
            temp /= 10;
        }
        bytes memory buffer = new bytes(digits);
        while (value != 0) {
            digits -= 1;
            buffer[digits] = bytes1(uint8(48 + uint256(value % 10)));
            value /= 10;
        }
        return string(buffer);
    }
}

testing script

const { expect, assert } = require("chai");
const { ethers } = require("hardhat");

describe("Library Test", function () {

    let Test, test, owner, addr1;

    beforeEach(async function () {
        Test = await ethers.getContractFactory("Strings");
        [owner, addr1] = await ethers.getSigners();
        test = await Test.deploy();
    })

    it("Strings test", async function () {
        const t1 = await test.toString(123);                     //error point
        console.log(t1);
    });
});

I changed a function name from toString to toStrin just for testing. and it works. function toString(uint256 value) public

function toStrin(uint256 value) public
                             &
const t1 = await test.toStrin(123);

So I thought it’s because js has the function with the same name. But although I tried callStatic function to override the js function, it still didn’t work.

const t1 = await test.callStatic["toString(uint256)"](123);

repeatedly same error TypeError: uniqueNames[name_1].push is not a function.

But expectedly const t1 = await test.callStatic["toStrin(uint256)"](123); with function function toStrin(uint256 value) public worked.

[ricmoo]

I may need to use Object.hasOwnProperty internally, as I might be using a null check. I’ll look into this as soon as possible.

[k06a]

This code was intended to be used as an internal library, not as a public methods 😃