Invalid ENS name error when a signer is used instead of an address

Hey @ricmoo

I’m creating this issue cause I’ve seen lots of people confused about an ENS related error being thrown when a signer is used instead of an address. To make things worse, the signer gets JSON.stringifyd so the error is HUGE sometimes.

Have you consider treating this as a special case and throwing something like “hey, you should use an address instead of a signer”? Or maybe add a toJSON to the abstract signer to at least avoid those huge errors?

[Legogris]

Example problematic code:

const C = await ethers.getContractFactory("Contract");
const [owner, addr1, ...addrs] = await ethers.getSigners();
const c = await Contract.deploy(owner);

Yields confusing error:

 Error: invalid ENS name (argument="name", value="<SignerWithAddress 0x10957970C51812dc3A010C7d01b70e0d17dc79A8>", code=INVALID_ARGUMENT, version=providers/5.0.22)

Fix:

const c = await Contract.deploy(owner.address);

I guess extra confusing for typescript users, as the types are happy with it, only breaks at runtime.

[ricmoo]

This has already been added to my local v6. You should actually generally call .getAddress() instead of .address, since .address is not part of the Signer API (most signers do not have synchronous access to their address).

For v5, I can add a condition like that to the JavaScript side, but cannot change the signature to allow Signer and Contract since that would break any existing sub-classes.