Misleading types for `EnsProvider.getResolver()`

The getResolver() method on the EnsProvider interface is declared with the following signature

export interface EnsProvider {
    getResolver(name: string): Promise<EnsResolver | null>;
}

The implementation of getResolver() can return null though https://github.com/ethers-io/ethers.js/blob/4e9394554b1f05400ea4e0529d33e1d4efe78247/packages/providers/src.ts/base-provider.ts#L1515-L1524

This leads to callers of getResolver() not anticipating null as the return value which leads to runtime errors even though type-checking passes. I’d expect the following signature.

export interface EnsProvider {
    getResolver(name: string): Promise<EnsResolver | null>;
}

[ricmoo]

I’m adding this locally for the next minor bump now. 😃

Keep in mind a large portion of the library will still have the same problem if you are. “anticipating” things to not be null. The library is overall designed around the strict error in the TypeScript checker turned off, so anything can return null.

This is changed in v6 (which uses strict errors), and has required a lot of little changes, and v6 is still not ready for a public beta yet. But for the most part in v5, these sorts of changes will not be made anymore…

[ricmoo]

The types have been updated in 5.5.0.

Thanks! 😃