NonceManager increments nonce even if transaction fails

I understand this isn’t trivial to fix fully, but if a transaction fails to send (e.g. with insufficient balance), the nonce is wrong afterwards and every future transaction also fails.

I think these easy cases should be fixable by just doing

try {
	const tx = await this.nonceManager.sendTransaction({
		to: i.address,
		value: parseEther(i.amount),
	});
} catch (e) {
	console.error("could not send tx", "nonce=", e?.transaction?.nonce);
	this.nonceManager._deltaCount--;
}

except inside the sendTransaction function

[garyng2000]

@phiresky yes, this nonce(which is not even nonce but really serial counter) thing is really bad. Imagine in real life you run a business and issued 10 checks to your suppliers and if the first one is not cashed, the other 9 can’t either. You would be out of business in no time.

We have to re-design our application to use multiple ‘agent’ wallet and put our serialization logic(if needed) in the contract logic itself. Though most of the time, there doesn’t need to have serialization. Say a typical ERC20(like the above situation), it would go through so long the balance is enough, regardless when the transaction is picked up(gas price can be different).

[roderik]

We have done some extensive work on this and I can tell you that what we have settled on is:

• some sort of ordered queue per sender
• blocking sending and verification that the TX was accepted by the node (is not “slow”)
• several retries + filling the gaps with empty tx and queuing the failed ones at the end of the queue
• a “transaction set” concept if you have dependent transactions in one go.

Now we do work on consortium chains, so we do not often have issues with nodes accepting TX and then halfway through losing one in the middle of a run.