Question: Warnings raised when there are Events with the same name but different inputs?

On ethers 5.0.2

Given the following ABI with two Transfer events with different inputs:

{
  "abi": [
    {
      "anonymous": false,
      "inputs": [
        {
          "indexed": true,
          "name": "from",
          "type": "address"
        },
        {
          "indexed": true,
          "name": "to",
          "type": "address"
        },
        {
          "indexed": false,
          "name": "value",
          "type": "uint256"
        },
        {
          "indexed": false,
          "name": "data",
          "type": "bytes"
        }
      ],
      "name": "Transfer",
      "type": "event"
    },
    {
      "anonymous": false,
      "inputs": [
        {
          "indexed": true,
          "name": "from",
          "type": "address"
        },
        {
          "indexed": true,
          "name": "to",
          "type": "address"
        },
        {
          "indexed": false,
          "name": "value",
          "type": "uint256"
        }
      ],
      "name": "Transfer",
      "type": "event"
    }
  ]
}

In contract form this would look like:

contract Test {
    event Transfer(address indexed from, address indexed to, uint256 value);
    event Transfer(address indexed from, address indexed to, uint value, bytes data);
}

When calling the above contract, ethers@5.02 logs the following warning:

Duplicate definition of Transfer 
(Transfer(address,address,uint256,bytes), 
  Transfer(address,address,uint256))

Source: https://github.com/ethers-io/ethers.js/blob/d817416bae2fbc7adb8391fd038613241b7ab8ba/packages/contracts/src.ts/index.ts#L630-L637

Why do we warn users for having Events with duplicate names? I would expect that the intention is to check for duplicate Event signatures, for example:

• [Transfer(address,address,uint256,bytes), Transfer(address,address,uint256)] is OK 👍 since they have different event signatures.
• [Transfer(address,address,uint256,bytes), Transfer(address,address,uint256,bytes)] is NOT OK 👎 because they have duplicate event signatures.

Is this because of the events API expecting an event name?

[ricmoo]

The main reason is because of how you would access them. If you have a single Transfer event, then you could use contract.events.Transfer to get the Transfer fragment. But if there are multiple, you need to use contract.events["Transfer(address, address,uint256"] for example.

Many of these issues go away in v6 which will use a Proxy, but for now this is something there isn’t a great way around. You can always lower the Logger logLevel to error if the console logs are too much an issue. 😃

[lukehutch]

Well could you please at least create a setting for disabling this warning on ES3? The user should be able to decide whether they care about it or not. I have hundreds of lines of this warning in my test output, and that obscures legitimate test output.