Using subresource integrity
See original GitHub issueJust wondering whether subresource integrity could be helpful when loading ethers-5.0.umd.min.js from the CDN rather than copying the file or loading it without subresource integrity.
I feel there are some benefits this would have, although I guess it is less decentralised than each site depending on ethers having its own copy.
I raise this as an issue because it would mean that the CDN copy would need to remain unchanged (unless it already always remains unchanged) and so it might be worth having finer granularity of versions served by the CDN.
Additionally, the CDN would need to serve the file with Access-Control-Allow-Origin: *
as mentioned under “Cross-Origin Resource Sharing and Subresource Integrity” here. It currently does not do this.
Also just want to say: this is an awesome project, thanks contributors and @ricmoo especially for your efforts!
Issue Analytics
- State:
- Created 3 years ago
- Reactions:1
- Comments:6 (3 by maintainers)
Top GitHub Comments
@ricmoo thanks!! That is awesome 🎉 It all seems to work correctly as far as I can tell.
This should now work, using the links to the
cdn-cors.ethers.io
links including in the release notes for each version. I’ve also back-filled all previous versions.Try it out and let me know if there is any problems.